search

PatrickAlphaC / smartcontract-lottery

MIT License
79 stars 113 forks source link

adding pytests fixtures for making the code cleaner #55

Closed neotod closed 2 years ago

neotod commented 2 years ago

adding .vscode dir to .gitignore

PatrickAlphaC commented 2 years ago

Thanks for making this!!

Could we use a different fixture name than lottary? It makes it really annoying to read...

neotod commented 2 years ago

@PatrickAlphaC yeah sure, actually I myself was going to choose lottary_contract for more clarity. But I saw that you named it just lottary in the code, so I changed that to lottary. I'll do the changes and make another PR.

PatrickAlphaC commented 2 years ago

My spelling isnt the best, thanks

PatrickAlphaC commented 2 years ago

And I guess I meant lottery instead of lottary... using lottary_contract is also a bit annoying 😅

Thanks again for this