search

PatrickDev14 / portfolio-v3

MIT License
1 stars 0 forks source link

Storybook integration #7

Closed PatrickDev14 closed 1 year ago

PatrickDev14 commented 1 year ago

Storybook ran migrations for missing-babelrc, React preset, and eslintPlugin

kee-oth commented 1 year ago

Let's finish this task and then update this PR to point to the new branch:

https://github.com/PatrickDev14/portfolio-v3/issues/8

PatrickDev14 commented 1 year ago

I know that was a simple statement but I'll have to break it down. We're expanding my GitHub syntax with every step. "finish this task" - does that mean merge the PR to the main branch? "update this PR to point to the new branch" - I can search for an example, but do you mean the development branch?

PatrickDev14 commented 1 year ago

development is now the base branch for this PR

kee-oth commented 1 year ago

I know that was a simple statement but I'll have to break it down. We're expanding my GitHub syntax with every step. "finish this task" - does that mean merge the PR to the main branch? "update this PR to point to the new branch" - I can search for an example, but do you mean the development branch?

Sorry, I meant "let's finish the task linked below (issue #8)". And yeah! I meant the development branch 👍

kee-oth commented 1 year ago

@PatrickDev14 I had a bunch of errors caused by this page: src/pages/mdx-page.mdx

I had to delete it in order for Storybook to work correctly. Are you able to keep that page and also run Storybook successfully?

PatrickDev14 commented 1 year ago

I tried a couple other approaches from the web, but ultimately src/pages/mdx-page.mdx was also an issue for me locally. It was my mistake not to test it before you comment 5 days ago. I'm merging this with the development branch.