PatrickF1 / fzf.fish

🔍🐟 Fzf plugin for Fish
MIT License
1.96k stars 78 forks source link

[Search directory] Prevent duplicate / when fd version >= 8.4.0 #241

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

fd 8.4.0 just released with this (long-awaited?) change:

Directories are now printed with an additional path separator at the end

This is different from how it is handled in fzf.fish, where directories are only appended a slash under strict conditions, so strict it may look like a bug. I'm saying this because I kinda think fzf.fish should have handled it like fd from the beginning.

Now onto the issue. Most programs treat duplicate slashes as one and work as intended, but it certainly does not look good. There are several possible solutions:

Not sure about how to revise the README, maybe just leave it as is, the tip is useful nonetheless. Or maybe drop the "and the only path selected" part.

kidonng commented 2 years ago

No idea why the tests failed, but as always I don't find tests interesting 😬

PatrickF1 commented 2 years ago

oh looks like you'll need to update the test too

PatrickF1 commented 2 years ago

Thanks @kidonng !