This is different from how it is handled in fzf.fish, where directories are only appended a slash under strict conditions, so strict it may look like a bug. I'm saying this because I kinda think fzf.fish should have handled it like fd from the beginning.
Now onto the issue. Most programs treat duplicate slashes as one and work as intended, but it certainly does not look good. There are several possible solutions:
Don't do our thing if fd version is >= 8.4.0. Easiest one, also how this PR is done currently. Just one trivial problem: people may notice a slight difference of fzf.fish when they bump fd, not intuitive.
Follow fd and append slashes to directories all the time. May not worth the effort as the code are going to be dropped when most users upgraded to newer fd version.
Go out of our way and drop all slashes from fd. In other words, keep fzf.fish's behavior consistent across fd versions. This solution is here only for completeness.
Not sure about how to revise the README, maybe just leave it as is, the tip is useful nonetheless. Or maybe drop the "and the only path selected" part.
fd 8.4.0 just released with this (long-awaited?) change:
This is different from how it is handled in fzf.fish, where directories are only appended a slash under strict conditions, so strict it may look like a bug. I'm saying this because I kinda think fzf.fish should have handled it like fd from the beginning.
Now onto the issue. Most programs treat duplicate slashes as one and work as intended, but it certainly does not look good. There are several possible solutions:
Not sure about how to revise the README, maybe just leave it as is, the tip is useful nonetheless. Or maybe drop the "and the only path selected" part.