search

PatrickF1 / fzf.fish

🔍🐟 Fzf plugin for Fish
MIT License
2k stars 81 forks source link

[Search history] don't merge history when in private mode #245

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

Calling history merge in private mode (fish --private) clears the session history. So if you execute the search history function while in private mode, there is no history to search.

PatrickF1 commented 2 years ago

Calling history merge in private mode (fish --private) clears the session history

Are you saying it clears the session history of the current session but leaves the other sessions' history intact, or it clears every session's history?

kidonng commented 2 years ago

Are you saying it clears the session history of the current session but leaves the other sessions' history intact, or it clears every session's history?

Just the current session (if it ever does the latter, I would be crying).

PatrickF1 commented 2 years ago

This seems like a bug that should be fixed in fish. Why would they cause it to clear history?

kidonng commented 2 years ago

But we can fix it now, instead of waiting for identifying if this is really an issue and fish release a new version with fix.

PatrickF1 commented 2 years ago

Sure! In the meantime, I've filed a bug report https://github.com/fish-shell/fish-shell/issues/9050

PatrickF1 commented 2 years ago

Oh wow bug already got fixed in fish-shell master. Looks like the fix is to make it error out so regardless, it was good that we merged this.