Closed acegallagher closed 2 years ago
Gotcha, that makes sense. I can see myself--though rare--selecting multiple commands to run. Okay I'll work on this.
There you go, requested changes made and committed
Thank you! So...a complication is that this doesn't work when you select a multi line command. I'll look into a solution when I have a significant contiguous chunk of free time some time later. But feel free to suggest ideas or fix it yourself.
Btw how do you comment and commit using two different GH accounts?
Ohhhhhhhhhhhh. There will have to be some sort of regex that only removes the date if present. Hilariously, the multi-account was unintentional. It's because I made the commit with an ssh key shared by both accounts (changed the key for one of them without thinking about it). Oops.
Alright, there's a solution. It will strip the date from any line the date exists by regex. I suppose there's potentially some conflict if there's a line that also has the exact format of the date but I have no idea how much that would matter to you. It wouldn't to me.
The regex now only matches the beginning of the string and no need for the if statement. Much cleaner. Also added multi!
Thanks <3
Thanks for putting in the work, Michael. I'll take it from here--just gotta update the readme and add a test and I'll merge!
No problem. Congratulations on having a readable well built project that's very useful. Will continue looking through the code and imagining other ways to contribute.
Great work Michael! Thank you for your mind words. Would you mind starring my repo? It's a goal of mine to reach 1k stars. :)
Resolves https://github.com/PatrickF1/fzf.fish/issues/251. Reply the issue I opened, here's the minor change. It's a big deal for my workflow to be able to cobble together scripts this way.
Hopefully it's helpful! Thanks