search

PatrickF1 / fzf.fish

🔍🐟 Fzf plugin for Fish
MIT License
1.96k stars 78 forks source link

[Search Directory] Ensure unaliased fd is called #280

Closed Susensio closed 1 year ago

Susensio commented 1 year ago

If fd is aliased, Search Directory will hang until fd finishes executing. This is because fish functions buffer. Resolves #281.

PatrickF1 commented 1 year ago

Re-opening based on further discussion in #281 .

Susensio commented 1 year ago

I've fixed one dangling alias that I've missed. It wasn't blocking but for completeness it should be unaliased too.

I don't know why the test are failing.

PatrickF1 commented 1 year ago

The test is failing for the same reason that the test is failing in #282.

PatrickF1 commented 1 year ago

Closing in favor of #282. A cursory search of GitHub "alias fdfind" reveals hundreds of lines of code that alias fd to fdfind even though the docs clearly say to use symlinks. 🤯️

Btw, next time, just update the same PR. 😉️