search

PatrickF1 / fzf.fish

🔍🐟 Fzf plugin for Fish
MIT License
2k stars 81 forks source link

feat: allow configuring FZF colors #284

Closed gregorias closed 1 year ago

gregorias commented 1 year ago

fzf.nvim already relies on highlighting done by fd and bat, but not all colors are set by them. This setting allows people to configure FZF colors not affected by fd or bat while keeping default options fzf.nvim provides.

PatrickF1 commented 1 year ago

Hi Grzegorz, thanks for the PR. How come you prefer this over just allowing the user to set the colors in FZF_DEFAULT_OPTS?

gregorias commented 1 year ago

Hi Grzegorz, thanks for the PR. How come you prefer this over just allowing the user to set the colors in FZF_DEFAULT_OPTS?

I prefer this, because setting FZF_DEFAULT_OPTS overrides the defaults that fzf.fish provides. This means that to keep those defaults, I would need to copy them into my own config and hope they don't change. Since the only thing I need is to set colors, it's a more maintainable set up for me if there's a configuration knob for that.

PatrickF1 commented 1 year ago

I prefer this, because setting FZF_DEFAULT_OPTS overrides the defaults that fzf.fish provides. This means that to keep those defaults, I would need to copy them into my own config and hope they don't change. Since the only thing I need is to set colors, it's a more maintainable set up for me if there's a configuration knob for that.

Ah that makes sense! I've long had on my todo list a way to set global fzf opts for all of fzf.fish and haven't had time to get to it. Would that resolve this need? I really don't want to make a fzf.fish flag that merely maps to a simple fzf flag.

PatrickF1 commented 1 year ago

I would need to copy them into my own config and hope they don't change

Btw, I promise FZF_DEFAULT_OPTS won't change, and even if it does it won't be a setting that is significant. Hope that'll allow you to just put it in there for now while I get working on the global fzf.fish opts.

gregorias commented 1 year ago

Ah that makes sense! I've long had on my todo list a way to set global fzf opts for all of fzf.fish and haven't had time to get to it. Would that resolve this need? I really don't want to make a fzf.fish flag that merely maps to a simple fzf flag.

Sounds reasonable to me. I'll just override FZF_DEFAULT_OPTS then. Feel free to close this PR.

Thanks.

PatrickF1 commented 1 year ago

Thanks for opening this issue and giving me insight into why people might not want to override FZF_DEFAULT_OPTS! When I get to it, I'll probably remove setting a default for it and just suggest it in the docs. It's definitely out of scope for the plugin to be messing with fzf globally.