PatrickJS / NG6-starter

:ng: An AngularJS Starter repo for AngularJS + ES6 + Webpack
https://angularclass.github.io/NG6-starter
Apache License 2.0
1.9k stars 1.35k forks source link

Adding webpack-dev-server #209

Closed washingtonsoares closed 2 years ago

washingtonsoares commented 7 years ago

Hey folks!

I really enjoyed this starter project and it helped me a lot when i was looking to start a project.

However I realized that it was possible to improve it in some points, among them:

Also I have updated some dev dependencies, like the loaders and the webpack itself.

I believe that these changes will bring improvements and more users to this starter project and will certainly continue to help many devs who are starting a project!

Kindly look at this PR, and Come to me if you need anything to be adjusted.

Thanks!

jayrmotta commented 7 years ago

:+1:

jvpsousa commented 7 years ago

👍

andrei-dracea commented 7 years ago

Who else needs to review this in order to merge it? What are the next steps?

fesor commented 7 years ago

The only problem that I see with this PR is that it removes browser-sync. This is pretty useful tool for cross-device testing.

Also there was some stuff which could be improved in webpack configuration management.

PatrickJS commented 7 years ago

@fesor is this PR good?

scragg0x commented 7 years ago

Could this plugin be used for browser-sync? I have never used it myself. https://www.npmjs.com/package/browser-sync-webpack-plugin