Closed washingtonsoares closed 2 years ago
:+1:
👍
Who else needs to review this in order to merge it? What are the next steps?
The only problem that I see with this PR is that it removes browser-sync
. This is pretty useful tool for cross-device testing.
Also there was some stuff which could be improved in webpack configuration management.
@fesor is this PR good?
Could this plugin be used for browser-sync? I have never used it myself. https://www.npmjs.com/package/browser-sync-webpack-plugin
Hey folks!
I really enjoyed this starter project and it helped me a lot when i was looking to start a project.
However I realized that it was possible to improve it in some points, among them:
Using webpack-dev-server: With webpack-dev-server it is possible to have a greater integration with webpack, Besides being a server with a very simple configuration to serve the webpack bundles.
Using Gulp only to generate new components: On Gulp I think it would only be necessary to generate new components, because the responsibles for generating the bundles would be webpack and the server for webpack-dev-server.
Also I have updated some dev dependencies, like the loaders and the webpack itself.
I believe that these changes will bring improvements and more users to this starter project and will certainly continue to help many devs who are starting a project!
Kindly look at this PR, and Come to me if you need anything to be adjusted.
Thanks!