search

PatrickJS / NG6-starter

:ng: An AngularJS Starter repo for AngularJS + ES6 + Webpack
https://angularclass.github.io/NG6-starter
Apache License 2.0
1.91k stars 1.35k forks source link

Dockerfile inclusion #235

Closed bernardocs closed 6 years ago

bernardocs commented 6 years ago

Hey guys!

I use this project as boilerplate of my project and I'm pretty satisfied with it.

I've been working on a Dockerfile for the project and wondered if anybody here have ever thought of creating one already. And if you did, why it was not already included?

I did a quick search through the issues section and didn't find any mention of it. I'm no Docker specialist as I'm using this oportunity to effectively learn more about it, but It would definitelly save the pain of going through known issues. 😄

PatrickJS commented 6 years ago

if you make a PR I wouldn't mind merging it

bernardocs commented 6 years ago

I'm on it! 😄

But as I said, I'm learning about Docker while I'm on it... So, I would appreciate some review!

I'll link a Pull Request here as soon as I make it work somehow...

bernardocs commented 6 years ago

It's on! #236

PatrickJS commented 6 years ago

thanks, merged