search

PatrickJS / NG6-todomvc-starter

Basic example of TodoMVC application written with angular and with use of components
https://angularclass.github.io/NG6-todomvc-starter/
MIT License
136 stars 73 forks source link

Wrong CommonsChunkPlugin minChunks argument #12

Closed andrewMuntyan closed 7 years ago

andrewMuntyan commented 8 years ago

Hi!

i've noticed minor bug in webpack config (webpack.config.js) it should have __dirname 'src', not 'client'

new webpack.optimize.CommonsChunkPlugin({
      name: 'vendor',
      minChunks: function (module, count) {
        return module.resource && module.resource.indexOf(path.resolve(__dirname, 'src')) === -1;
      }
    })

Also there is similar issue in webpack.dev.config.js file it should be

config.output = {
  filename: '[name].bundle.js',
  publicPath: '/',
  path: path.resolve(__dirname, 'src')
};