search

PatrickJS / PatrickJS-starter

MFE Starter
MIT License
10.33k stars 4.89k forks source link

package.json is missing some dev dependencies #226

Closed lzbgt closed 8 years ago

lzbgt commented 8 years ago

full deps should be as below:

"devDependencies": {
    "arrify": "*",
    "bluebird": "*",
    "blueimp-tmpl": "*",
    "colors": "^1.1.2",
    "copy-webpack-plugin": "^0.3.3",
    "css-loader": "^0.23.0",
    "enhanced-resolve": "0.9.1",
    "exports-loader": "0.6.2",
    "expose-loader": "^0.7.1",
    "file-loader": "^0.8.4",
    "findup-sync": "^0.3.0",
    "html-webpack-plugin": "^1.7.0",
    "http-server": "^0.8.5",
    "imports-loader": "^0.6.4",
    "inflight": "^1.0.4",
    "inherits": "^2.0.1",
    "istanbul-instrumenter-loader": "^0.1.3",
    "json-loader": "^0.5.3",
    "json5": "^0.4.0",
    "karma": "^0.13.15",
    "karma-chrome-launcher": "^0.2.1",
    "karma-coverage": "^0.5.3",
    "karma-jasmine": "^0.3.6",
    "karma-phantomjs-launcher": "^0.2.1",
    "karma-sourcemap-loader": "^0.3.6",
    "karma-webpack": "1.7.0",
    "loader-utils": "*",
    "lodash": "3.10.1",
    "minimatch": "*",
    "node-dir": "*",
    "object-assign": "*",
    "once": "^1.3.3",
    "path-is-absolute": "^1.0.0",
    "phantomjs": "^1.9.18",
    "phantomjs-polyfill": "0.0.1",
    "protractor": "^3.0.0",
    "raw-loader": "0.5.1",
    "reflect-metadata": "0.1.2",
    "remap-istanbul": "^0.5.1",
    "rimraf": "^2.4.4",
    "semver": "*",
    "style-loader": "^0.13.0",
    "ts-helper": "0.0.1",
    "ts-loader": "^0.7.2",
    "tsconfig-lint": "^0.4.3",
    "tslint": "^3.2.0",
    "tslint-loader": "^2.1.0",
    "typedoc": "^0.3.12",
    "typescript": "^1.7.3",
    "typings": "^0.6.1",
    "underscore": "^1.8.3",
    "underscore.string": "^3.2.2",
    "url-loader": "^0.5.6",
    "webpack": "^1.12.9",
    "webpack-dev-server": "^1.12.1",
    "webpack-md5-hash": "0.0.4"
  },
PatrickJS commented 8 years ago

can you make a pull-request

ApiStack commented 8 years ago

PR created: patched with full dev deps #228 @ApiStack is another account of @lzbgt

PatrickJS commented 8 years ago

@ApiStack so did you run into an error without these are were these mentioned as hidden modules or something?

lzbgt commented 8 years ago

@gdi2290 Just tested under OSX, the webpack runs without any error. But don't know why it fails on windows.

PatrickJS commented 8 years ago

it could also be the version of node/npm

lzbgt commented 8 years ago

@gdi2290, the vendor bundle is too big for use, any idea to make it succinct?

compiled against webpack.prod.config.js with ENV=production
Bruce@Bruces-MacBook ~/w/a/angular2-webpack-starter> ls -ltrh dist/vendor*.js
-rw-r--r--  1 Bruce  staff   1.1M Jan 15 10:52 dist/vendor.a3669eee36a1d0c22dbc.bundle.js
PatrickJS commented 8 years ago

The Angular team is working on better ways to lower the bundle size. For example, the compiler could be removed from the bundle as well Rx modules that aren't used. Because the framework is still in beta the problem was pushed back until now so I'm sure every new release will be improving the bundle size.