PatrickJS / PatrickJS-starter

MFE Starter
MIT License
10.33k stars 4.89k forks source link

PrimeNG integration #411

Closed bPopovska closed 8 years ago

bPopovska commented 8 years ago

Does anyone have experience with integrating the primeNG library in a webpack based project? Trying to integrate it in this starter results in the following error:

Error: No Directive annotation found on Button at new BaseException (http://localhost:3000/main.bundle.js:1318:24) at DirectiveResolver.resolve (http://localhost:3000/main.bundle.js:11928:16) at RuntimeMetadataResolver.getDirectiveMetadata (http://localhost:3000/main.bundle.js:32492:52) at http://localhost:3000/main.bundle.js:32549:63 at Array.map (native)

PatrickJS commented 8 years ago

there are two versions of Angular 2 installed. they need to update their angular2 dep or set as a peerDep

PatrickJS commented 8 years ago

see https://github.com/primefaces/primeng/pull/86

cagataycivici commented 8 years ago

Merged now, thank you.

https://github.com/primefaces/primeng/issues/88

PatrickJS commented 8 years ago

@cagataycivici thanks

Sicaine commented 8 years ago

@bPopovska did you get it running? We have basics running but datepicker makes trouble :(

bPopovska commented 8 years ago

@Sicaine Still running into issues. Can't get primeng to work when source maps are enabled. Also, the widget styles do not load properly. Have you stumbled upon the same issues?

luchillo17 commented 8 years ago

@bPopovska Are the widget styles issues you talk about related to the images urls of the style? i'm using sass-loader and as it just process the import statement as if that theme content were copied to the importing file, it breaks the images urls since now that content is in a different folder.

cagataycivici commented 8 years ago

I've done a fork to add PrimeNG for the UI;

https://github.com/cagataycivici/angular2-webpack-starter

luchillo17 commented 8 years ago

@cagataycivici Does dialogs work in yours? the errors above i fixed using the url loader but now i have issues when using the Dialog and seems related to jquery.

cagataycivici commented 8 years ago

Yes, it works for me in my fork above.

aminebizid commented 8 years ago

I don't use assets for Css I just do a require on node modules in app.ts

Envoyé de mon iPhone

Le 21 avr. 2016 à 23:12, Çağatay Çivici notifications@github.com a écrit :

I've done a fork to add PrimeNG for the UI;

https://github.com/cagataycivici/angular2-webpack-starter

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

luchillo17 commented 8 years ago

@cagataycivici Maybe my error is related to the way jquery is loaded due to me using the NgUpgrade package to try and update an Ng1 app? i'll take a deeper look at your starter and see what's the issue. 😄