search

PatrickJS / angular-hmr

:fire: Angular Hot Module Replacement for Hot Module Reloading
https://patrickjs.com
Apache License 2.0
507 stars 45 forks source link

The <app> is not removed upon hmr run #69

Closed rishabhmhjn closed 7 years ago

rishabhmhjn commented 7 years ago

I have been using hmr as per the configuration mentioned in @AngularClass/angular-starter example. I am facing an issue that when hmr runs, the old version of the root <app> component is not removed from the DOM.

Here is the screenshot of the elements. The first instance is the latest created element and the ones below are the old ones which are not being removed from the DOM.

screenshot 2017-09-01 13 05 39

Is there anything that I might be missing? Thank you so much for this library and your support

kubal5003 commented 7 years ago

I actually have the opposite problem - the old node is perfectly removed, new one is added, but nothing happens then - it's just an empty custom node and the application is not restarting and the whole tree of components is not regenerated..

PatrickJS commented 7 years ago

The old problem should be solved in the latest version. For @kubal5003 do you have async routes?

rishabhmhjn commented 7 years ago

@gdi2290 the new version solved it. Thanks a tonne 👍 Closing this one