search

PatrickJS / angular-hmr

:fire: Angular Hot Module Replacement for Hot Module Reloading
https://patrickjs.com
Apache License 2.0
505 stars 46 forks source link

commonjs dependencies #85

Closed w4-hanggi closed 3 years ago

w4-hanggi commented 4 years ago 
... src/hmr.ts depends on @angularclass/hmr. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

I got this warning, is there something wrong?

ronnyek commented 4 years ago

I believe this is a new warning introduced by angular10. I just started seeing it after an upgrading a project to angular 10

smorcuend commented 4 years ago

@w4-hanggi You can add this dependency to your angular.json in this way to remove de Warning with ng10:


          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "allowedCommonJsDependencies": [
              "hammerjs",
              "@angularclass/hmr"
            ]