search

PatrickJS / angular-md5

md5 for Angular.js and Gravatar filter
MIT License
132 stars 55 forks source link

Filters have to be included separately to make them work. #3

Closed juangabreil closed 10 years ago

juangabreil commented 10 years ago

It's not enough to add 'ngMd5' to dependencies you have also to add 'gdi2290.gravatar-filter' and 'gdi2290.md5-filter' if you want to use them.

It can be fixed by updating module declaration:

angular.module("angular-md5", [ "gdi2290.md5", "gdi2290.md5-filter", "gdi2290.gravatar-filter" ]);
angular.module("ngMd5", [ "gdi2290.md5", "gdi2290.md5-filter", "gdi2290.gravatar-filter" ]);

EDIT:

I've seen that the latest code has this dependencies added but distribution files are not updated with it. Anyway, I have tried to build the latest code and it still does not work...

PatrickJS commented 10 years ago

Sorry for the breaking change and thanks for taking the time to report it. There was a naming collision in the module definition for 'gdi2290.md5' and it's child module for the md5 service 'gdi2290.md5' fixed https://github.com/gdi2290/angular-md5/commit/39f9cd2f3fa71a9601a52dd6d659cc9a8a0f3755

you may now update your bower package version to v0.1.7