search

PatrickJS / angular-websocket

:arrow_upper_left: The missing Angular WebSocket module for connecting client applications to servers by @AngularClass
https://angularclass.github.io/angular-websocket
MIT License
1.22k stars 195 forks source link

Allow ws options to be passed to constructors #107

Closed el-chogo closed 6 years ago

el-chogo commented 8 years ago

This complies with the way ws behaves and is useful for specifying "low-level" ws options such as adding additional headers to the request (use case: authentication through jwt).

No breaking changes have been done by this commit.

LeastOne commented 8 years ago

@clinoge, good addition, thanks for making the contribution.

Does anyone know when this might be merged?

b264 commented 7 years ago

:+1:

b264 commented 7 years ago

@gdi2290 Do you know if anything is blocking this merge and release?

notVitaliy commented 7 years ago

@clinoge Can you update the readme and changelog for this feature?

ghost commented 7 years ago

@clinoge How would I add the header to the connection string?

        var wsTransactions = $websocket('wss://URL:8090/access/transactions', {
            reconnectIfNotNormalClose: true
        });
b264 commented 6 years ago

bump

b264 commented 6 years ago

:+1: