search

PatrickJS / angular-websocket

:arrow_upper_left: The missing Angular WebSocket module for connecting client applications to servers by @AngularClass
https://angularclass.github.io/angular-websocket
MIT License
1.22k stars 195 forks source link

onOpen / onClose outside digest loop #53

Closed 0cv closed 8 years ago

0cv commented 8 years ago

Looks like onOpen and onClose event are outside the event loop (forcing the use of a manual rootScope.apply). Maybe the same for onError.

wolever commented 8 years ago

+1 — this was very confusing.

Quas94 commented 8 years ago

+1 - this should definitely be added to the readme.

PatrickJS commented 8 years ago

thanks for the issue, the latest version should have this working :+1: