search

PatrickJS / es7-reflect-metadata

Webpack and Universal support for reflect-metadata refactored by @gdi2290
Apache License 2.0
14 stars 2 forks source link

What does `es7` mean? #2

Open lacolaco opened 8 years ago

lacolaco commented 8 years ago

I have a question. I couldn't understand what the name, es7-reflect-metadata, means.

Draft of ES7 (should be called as ES2016) has been snapshotted already. ReflectMetadata never be included by ES7.

https://twitter.com/bterlson/status/692424625813377026

I think this package is just a fork of reflect-metadata package for supporting UMD and Webpack. Why did you name this es7-reflect-metadata?

Thank you.

PatrickJS commented 8 years ago

it's a fork of reflect-metadata and I just added the es7 just because I wanted a version that worked with webpack without having to include the package in noParse. It's better universal support but I have to keep the repo in sync with reflect-metadata https://github.com/gdi2290/es7-reflect-metadata/blob/master/package.json#L6...L14

lacolaco commented 8 years ago

Yes, I know the purpose of this fork and I think it's reasonable and necessary. But sorry, to be honest, I want you to change the incorrect name before angular depended on this.

For example in angular, es6-promise and es6-collections are the feature of ECMAScript 6 actually. But es7-reflect-metadata is not similar meaning.

I think this package should be named universal-reflect-metadata or reflect-metadata-universal.

PatrickJS commented 8 years ago

yup, universal-reflect-metadata makes more sense

lacolaco commented 8 years ago

Thank you for understanding. :smiley: