Dependency graph is not properly generated if there is no empty line above '\begin{theorem}'

[ianjauslin-rutgers]

I ran into an issue where the dependency graph is not generated properly if the line preceding '\begin{theorem}' or '\begin{definition}' is not empty.

Setup:

• leanblueprint: latest commit (a377de0)
• plastex: 3.0

Steps to reproduce: use the following tex file:

\usepackage{amsmath, amsthm}
\usepackage[showmore, dep_graph, coverage, project=../../]{blueprint}

\newtheorem{theorem}{Theorem}

\begin{document}

tt
\begin{theorem}
  \label{tt:test}
  Test
\end{theorem}

\begin{proof}
test
\end{proof}

tt
\begin{theorem}
  \label{tt:test2}
  Test
\end{theorem}

\begin{proof}
\uses{tt:test}
test uses \ref{tt:test}
\end{proof}

\end{document}

The dependency graph does not show the dependency between test and test2. It works fine if the lines before the theorems are blank.

[SriAR]

My codebase is horribly mangled so I cannot submit a PR for this right now, but one fix is to change

https://github.com/PatrickMassot/leanblueprint/blob/7ce2f47fc5ed955b4d473e8c14d93ea702ad4c48/leanblueprint/Packages/blueprint.py#L321-L322

to

        if childNodes:
            for grandchildNode in childNodes:
                if grandchildNode.nodeName == 'thmenv':
                    return grandchildNode

[PatrickMassot]

Could you please test again with plastex's master branch? I pushed a fix there which should be relevant.

[PatrickMassot]

Correction: I realized my "fix" was incorrect so I reverted it. Sorry about the noise. I will continue to investigate.

[PatrickMassot]

It should be good now.