search

PatrickRoumanoff / nexus-crowd-plugin

Sonatype Nexus plugin for Atlassian Crowd integration
http://patrickroumanoff.github.io/nexus-crowd-plugin/
40 stars 20 forks source link

Crowd plugin doesn't work with Nexus 3.0 #21

Closed splatch closed 9 years ago

splatch commented 9 years ago

I did a test run of crowd plugin for Nexus 3.0 and certainly it doesn't work.

Mainly due to API changes some portions of code are unecessary and some of the methods are never called:

All these issues results in NullPointerExceptions thrown, even when realm is configured properly. Over weekend I found that sisu injects properly new things only over constructors and does not handle @PostConstruct and @PreDestroy annotations (this requires org.eclipse.sisu.bean.LifecycleModule, however I don't know how to wire it in).

More over Karaf feature descriptor is broken and it does not include nexus-crowd-plugin bundle itself.

PatrickRoumanoff commented 9 years ago

Nexus 3.0 is not out yet (only the preelease is out), master contains changes that work against that pre release. I am waiting for the actual release before releasing a version of the plugin that will work against it. The security API seems to have breaking changes in every single dot release, and 3.0 is a massive refactoring of their code and the plugin API, after all Sonatype moved nexus to OSGi and Karaf as part of 3.0. You seem to understand what's not working, so you are welcome to review the changes I put against master and validate it's working for you.

splatch commented 9 years ago

Hey Patrick, I am aware of runtime issues, however I am not fluent with most of sonatype/nexus related things such sisu. I examined issues by using latest milestone build available. If API is still not finalized its fine to wait untill release.

Best regards, Lukasz