search

PatrickSannes / BetterLogic

A advanced logic library for homey
9 stars 8 forks source link

request: Betterlogic devices are not fully following homeys Json standard #13

Open Heki2017 opened 7 years ago

Heki2017 commented 7 years ago

Hi Patrick, first of all big thanks for creating this app as it makes Homey so much more useful. I am happy coding with BL on Homey, however I have, when interfacing with Homey, some issues as the Json returned from a betterlogic device is not fully code compliant.

The label is not coded in En and/or Nl, but straight put in the label. For your variables it is code compliant. It is possible for me to circumvent it by coding, but I prefer to stay strict (I assume Athom would also encourage that). It would be great if you could make it compliant with Homey in next revision.

I promise a a few glasses of good beer/ cups of good coffee to donate.

See below examples:

a Variable gives

decimals = 2 enabled = 1 labels = { en = "cooker-eind-stand"; } name = cooker-eind-stand type = number units = Value uri = homey:app:net.i-dev.betterlogic type = app uriId = net.i-dev.betterlogic uriName = Better Logic uriIcon = /app/net.i-dev.betterlogic/assets/icon.svg zone =

a Device gives

decimals = 2 enabled = 0 labels = Volume Sonos kamer name = dim type = number units = uri = homey:device:5d0b686e-bf6b-411d-b075-646a5309dab4 type = device uriId = 5d0b686e-bf6b-411d-b075-646a5309dab4 uriName = Volume Sonos kamer uriIcon = /app/net.i-dev.betterlogic/assets/icon.svg zone = experimenteer lab

PatrickSannes commented 6 years ago

Sry for the late response. This would be very hard to fix because it will break the current apps. I guess people will kill me for it. Ill see if I can make it so new devices will be correctly formatted and old ones stay like they are... Is your problem only with the label?

Heki2017 commented 6 years ago

OK Patrick, thanks for coming back to me. I have my work around it. So no need to change.

Thanks for your great app, it really makes Homey more useful,

regards

Op 28 nov. 2017, om 21:56 heeft Patrick Sannes notifications@github.com het volgende geschreven:

Sry for the late response. This would be very hard to fix because it will break the current apps. I guess people will kill me for it. Ill see if I can make it so new devices will be correctly formatted and old ones stay like they are... Is your problem only with the label?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PatrickSannes/BetterLogic/issues/13#issuecomment-347660697, or mute the thread https://github.com/notifications/unsubscribe-auth/AZM_o8hIXGHKcS2ZGPN14R26FTPR_IAAks5s7HNggaJpZM4Onkyg.