PatrikTrestik / homeassistant-solax-http

Home assistant integration for SolaX EV Charger HTTP API
Apache License 2.0
21 stars 1 forks source link

Wrong Charge Phase mapping for sw ver 1.13 #36

Closed josefburger closed 5 months ago

josefburger commented 5 months ago

Hello, I have a problem with registr mapping, in my opinion you are using the wrong registr number. You are using 0x625, but it is now 0x63B.

case 0x625: return [{"reg":70,"val":f"{payload}"}]

image image

PatrikTrestik commented 5 months ago

I'll fix it, but it will be little harder. I have to add version check not to break older fw.

@josefburger please share latest Modbus mapping. Doc or link. Thanks.

josefburger commented 5 months ago

I'm sorry, I forgot to attach EvCharger ModbusRTU V3.5.pdf

josefburger commented 5 months ago

Register "reg":70 doesn't change anything at all, you know the new reg number for http api? I can't make it out.

PatrikTrestik commented 5 months ago

Register "reg":70 doesn't change anything at all, you know the new reg number for http api? I can't make it out.

There is no official document for API. All I have is reverse engineering from Android app. I have to check if there is new version and decompile again.

I use ModbusReg numbers only to keep reference to solax-modbus. Actual number have no meaning in this code. But I think that with change in modbus they also changed API. Researching.

PatrikTrestik commented 5 months ago

If you have 3 phase changer, this setting has no meaning. Even SolaxCloud app is not showing it.

For 1-phase it is indicating which wire is changer connected on to correctly report to Inverter. It should work with API as is now.

PatrikTrestik commented 5 months ago

I decompiled latest SolaxCloud app and checked mapping. There is nothing significantly new on API.

I agree that Modbus reg id is different, but because it has no functional meaning here, I'll not change it.

If you find it not working, please try to simulate correct function with SolaxCloud app and make screenshots. I can than try to find same in code.

Closing the bug, but feel free to reopen.

josefburger commented 5 months ago

If you have 3 phase changer, this setting has no meaning. Even SolaxCloud app is not showing it.

Oh, I thought I could switch the charger from three to single phase. In that case, sorry for the unnecessary ticket.