Patrowl / PatrowlEngines

PatrOwl - Open Source, Free and Scalable Security Operations Orchestration Platform
https://www.patrowl.io
GNU Affero General Public License v3.0
242 stars 73 forks source link

Deleted dependency detected #431

Closed ashishbijlani closed 8 months ago

ashishbijlani commented 8 months ago

I'm a Cyber Security researcher and developer of PackjGuard [1] to address open-source software supply chain attacks.

Issue

During my research, I found that this repo is vulnerable to attack due to deleted dependency from the public PyPI registry.

Details

Specifically, file https://github.com/Patrowl/PatrowlEngines/blob/f428ed26425dd5fdb218fa9d9be60c660ce7ba9b/engines/ssllabs/requirements.txt lists nesutils as one of the dependencies. However, it has been deleted from public PyPI. As such, an external bad actor can claim that name and register a malicious package, which will be then installed with pip install command, resulting in arbitrary remote code execution.

Impact

Not only your apps/services using https://github.com/Patrowl/PatrowlEngines repo code are vulnerable to this attack, but the users of your open-source Github repo could also fall victim.

You could read more about such attacks here: https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610

Remediation

Please manually register a placeholder nesutils package on PyPI immediately or remove nesutils dependency from https://github.com/Patrowl/PatrowlEngines/blob/f428ed26425dd5fdb218fa9d9be60c660ce7ba9b/engines/ssllabs/requirements.txt to fix this vulnerability.

To automatically fix such issues in future, please install PackjGuard Github app [1].

Thanks!

  1. PackjGuard is a Github app that monitors your repos 24x7, detects vulnerable/malicious/risky open-source dependencies, and creates pull requests for auto remediation: https://github.com/marketplace/packjguard
ashishbijlani commented 8 months ago

Sorry for this false positive.