An Option Page for configuration variable could be very useful

Patrowl / PatrowlManager

PatrOwl - Open Source, Smart and Scalable Security Operations Orchestration Platform

https://www.patrowl.io

GNU Affero General Public License v3.0

621 stars 112 forks source link

An Option Page for configuration variable could be very useful #196

Open vtasio opened 3 years ago

vtasio commented 3 years ago

A page that configuration such as the below could be saved/changed and used:

Scan Engine Max retries
Number of second to wait before perform a request to scan engine
In how many items to split the assets during scan
Haw many concurrent jobs to start
etc...

MaKyOtOx commented 3 years ago

hi @vtasio : great idea. We could also use the Settings model for global configuration parameters ?

vtasio commented 3 years ago

To tell you the truth , i have not used that menu at all. But i think i got it . You can use in setting all the variable that can be found in https://github.com/Patrowl/PatrowlDocs/blob/master/installation/patrowlmanager-settings.md and override the one's in the config files ?

Probably not all , i think you are only using it for the "Alert notification settings" on the above link ?

MaKyOtOx commented 3 years ago

Yes, it would be nice. We just have to clearly specify a priority order. Example: Scan Settings > Engine Settings > Global Settings > Environment variables

MaKyOtOx commented 3 years ago

Yes, I'm just using the Settings model for notification settings. BTW, it could be extended to all global variables ?

vtasio commented 3 years ago

I will try to find a way to make but, this might be a little more complicated for my knowledge. If you start with something that i can rely on (before me ), i believe i could extend it .

vtasio commented 3 years ago

Question: are you setting up somewhere the number of Jobs to it is the outcome of asset split during scan ? for example 400 assets scan , splited by 100 . This will produce 4 concurrent jobs ?