search

Patryk27 / kartoffels

a game where you're given a potato and your job is to implement a firmware for it
https://kartoffels.pwy.io
GNU General Public License v3.0
230 stars 6 forks source link

Enable Link-Time Optimization (LTO) #34

Closed zamazan4ik closed 2 months ago

zamazan4ik commented 2 months ago

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit (in this case, it's not critical at all but anyway).

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO also will be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO also should help.

Thank you.

Patryk27 commented 2 months ago

Makes sense, thanks for the tip!