search

Pattern-Projector / pattern-projector

https://www.patternprojector.com/
MIT License
87 stars 19 forks source link

Add diagonal measurement to calibration #218

Open courtneypattison opened 7 months ago

courtneypattison commented 7 months ago

As per Sasha's suggestion in #203. I'm thinking maybe a modal that shows a few common scenarios for incorrect calibration, e.g. a image of an off by 1 width/height and bent lines from an uneven table/mat.

hluedeke commented 6 months ago

Another one to throw in here (I think): What if we showed a warning if the calibration grid coordinates don't make sense?

Eg: if someone enters 16in x 24in, and the 16in side is actually longer than the 24in side in actual coordinates, that would generate a warning (maybe take the average of both vertical edges and both horizontal edges to get the comparison value). If they enter 16in x 16in then there would never be a warning.

courtneypattison commented 6 months ago

What if we showed a warning if the calibration grid coordinates don't make sense?

I've been thinking about this one as well! I'm hesitant to put warnings because they send people into a panic but I think if it were well tested and only showed up in cases where we're pretty confident the numbers are off it'd be helpful rather than stressful. I don't usually input my width and height until after I've matched up my corners.