Code style changes, add support for extra endpoints.

PatternBuilder / pattern-kit

A REST server for your Component API based Design System

20 stars 10 forks source link

Code style changes, add support for extra endpoints. #11

Closed SiliconValet closed 7 years ago

SiliconValet commented 7 years ago

Added doc blocks for files, functions.
Consistent whitespacing / formatting.
Add rest endpoint for listing patterns.
Add functionality to render endpoint for web component, fragment and son response.
Add debouncer to the schema editor to prevent DDOS.

siwinski commented 7 years ago

@SiliconValet THANK YOU! Me and/or @andrewmriley will review this as soon as we can -- most likely whenever it gets prioritized for us.

siwinski commented 7 years ago

@SiliconValet would you mind using php-cs-fixer (i.e. php-cs-fixer fix .) for PSR-1 and PSR-2 coding standards instead of using Drupal coding standards since this is a PHP project and not a Drupal project?

siwinski commented 7 years ago

@SiliconValet would you mind using php-cs-fixer (i.e. php-cs-fixer fix .) for PSR-1 and PSR-2 coding standards instead of using Drupal coding standards since this is a PHP project and not a Drupal project?

@SiliconValet I just added php-cs-fixer as a dependency (#14) so if you merge master and update your Composer dependencies you can just run composer cs

SiliconValet commented 7 years ago

Testing...

SiliconValet commented 7 years ago

Works here. Looks good for merge. I don't know how to run a comprehensive test of all the things you guys use, so if you have something, use it.

SiliconValet commented 7 years ago

bump for review/merge

siwinski commented 7 years ago

@SiliconValet please remove the webrh library-specific stuff

siwinski commented 7 years ago

@SiliconValet why the close?

siwinski commented 7 years ago

@SiliconValet why the close?

Nevermind.... I just saw the new merge request