Closed SiliconValet closed 5 years ago
Yeah! Someone is finally cleaning up my crappy old code :D If you see something and think "wow thats a horrible hack!", yes it was. This was my first (and probably last) php project of this scale. Thanks for giving it some polish.
I've got plenty of my own mess in there now, blame is slowly becoming mine.
Great concepts in there, works great as a dynamic templating engine. Most of what I've done with it is just housekeeping and stuff to extend the RESTful stuff. Thanks for the hard work!
I'm glad someone is enjoying and appreciating it! Have you heard about the movement in PHP pattern lab to introduce some of the same ideas? They specifically reference this project.
yeah, Derek Reese is driving a lot of that and some of those ideas are coming from this effort.
On Fri, Sep 1, 2017 at 2:27 AM, Micah Godbolt notifications@github.com wrote:
I'm glad someone is enjoying and appreciating it! Have you heard about the movement in PHP pattern lab to introduce some of the same ideas? They specifically reference this project.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PatternBuilder/pattern-kit/pull/20#issuecomment-326500849, or mute the thread https://github.com/notifications/unsubscribe-auth/AArcNqv_MW-RolAbE1lm7j9Usc5g5LHIks5sd6PMgaJpZM4PHrIp .
@SiliconValet & @micahgodbolt It seems like this MR is getting a little stale. I'm wondering what state of review this MR is in? Is it close to being mergeable? Does it change any functionality and if so, should we tie it to a major release?
I'm not really in a position to review it at the moment.
@micahgodbolt Understandable! I just saw you were in the discussion so I wanted to cc you. I was more asking @SiliconValet to see where this was in review.
Thanks :)
On Fri, Apr 6, 2018, 7:38 AM Cassondra notifications@github.com wrote:
@micahgodbolt https://github.com/micahgodbolt Understandable! I just saw you were in the discussion so I wanted to cc you. I was more asking @SiliconValet https://github.com/SiliconValet to see where this was in review.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PatternBuilder/pattern-kit/pull/20#issuecomment-379273443, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXlTFhJQ8ikAZhrXar3Id-ZXzx7mgV-ks5tl33LgaJpZM4PHrIp .
@SiliconValet can you provide testing & setup instructions?
@SiliconValet used composer-link
to test this locally with WebRH's PK implementation. Everything works as expected. I would say that this PR is ready to merge.