PatternBuilder / pattern-kit

A REST server for your Component API based Design System
20 stars 10 forks source link

WIP Update bootstrap and styles #28

Closed castastrophe closed 3 years ago

castastrophe commented 4 years ago

Instructions for testing:

In the repository using PatternKit (webrh for example), update the composer.json file to:

    "require": {
        "pattern-builder/pattern-kit": "*"
    }
repositories": [{
      "type": "path",
      "url": "/Users/carobert/Projects/pattern-kit",
      "options": {
        "symlink": true
      }
    }, {
      "type": "vcs",
      "url": "https://github.com/PatternBuilder/pattern-kit"
}]

^ Put your local path to pattern-kit repository here

Run rm composer.lock && composer require pattern-builder/pattern-kit @dev. Kick off the watch task (npm run watch)

castastrophe commented 4 years ago

Instructions for testing:

  1. In the repository using PatternKit (webrh for example), update the composer.json file to:
    "require": {
        "pattern-builder/pattern-kit": "*"
    }
repositories": [{
      "type": "path",
      "url": "/Users/carobert/Projects/pattern-kit",
      "options": {
        "symlink": true
      }
    }, {
      "type": "vcs",
      "url": "https://github.com/PatternBuilder/pattern-kit"
}]

^ Put your local path to pattern-kit repository here

  1. Run rm composer.lock && composer require pattern-builder/pattern-kit @dev.
  2. Kick off the watch task (npm run watch)
castastrophe commented 4 years ago

If that testing process doesn't work ^ you can also just copy the folders from the pattern-kit repo into the vendors directory in webrh. 🤷‍♀

castastrophe commented 4 years ago

This branch needs some clean-up for styles.

starryeyez024 commented 4 years ago

@castastrophe maybe this could be split up into a few smaller PRs:

  1. JSON editor styles
  2. Menu / Styleguide styles
  3. Update URL button functionality

I'm seeing a handful of issues:

starryeyez024 commented 4 years ago

sorry, just saw that testing instructions are in a comment (I just saw the empty description), however this:

repositories": [{
      "type": "path",
      "url": "/Users/carobert/Projects/pattern-kit",
      "options": {
        "symlink": true
      }
    }, {
      "type": "vcs",
      "url": "https://github.com/PatternBuilder/pattern-kit"
}]

doesn't match the syntax of the composer file?

castastrophe commented 4 years ago

@starryeyez024 I wouldn’t spend much time on this. I merged master into it and it broke a lot of the work I had done because there were so many changes. 😢

starryeyez024 commented 4 years ago

@castastrophe doh! Could we still salvage the Update URL button? That is super useful!

starryeyez024 commented 4 years ago

Also that's weird, I only see one very small commit in Dec 2019 to this repo? https://github.com/PatternBuilder/pattern-kit/commits/master