PatternBuilder / pattern-kit

A REST server for your Component API based Design System
20 stars 10 forks source link

Removing agnostic links and adding strict https://. #7

Closed joecodecreations closed 7 years ago

joecodecreations commented 7 years ago

This resolves a problem where the pages are failing to load, taking too much time to lookup cdn resources. Setting to strict HTTPS instead of agnostic seem to resolve the issue.

siwinski commented 7 years ago

I agree that the file in this change is incorrect in referencing both // and https:// assets, however, IMO the correct fix is setting everything to //. Hard-coding to a particular protocol should not happen because browsers and/or security settings can change their behavior regarding cross-protocol assets so using protocol-relative URLs (i.e. //) should be used.

joecodecreations commented 7 years ago

While I agree that typically using protocol-less URLs are the preferred method, I am having issues with the pages loading when they are using them. When I switch them to a more strict protocol format, the issues are no longer present.

Video or page loading: https://drive.google.com/a/redhat.com/file/d/0B9c3YeTOuOveaDMyVXlEYmhxemc/view?usp=sharing

micahgodbolt commented 7 years ago

/waves

siwinski commented 7 years ago

@micahgodbolt HELLO STRANGER!

@joecodecreations i was just doing a drive-by comment. @andrewmriley will need to do the review and merge.

starryeyez024 commented 7 years ago

:+1: