search

Patternslib / Patterns

Library for quickly applying rich interaction patterns without the need to write any JavaScript.
http://patternslib.com
Other
104 stars 43 forks source link

Create a pat-masonry based on pat-packery #384

Closed pilz closed 9 years ago

pilz commented 9 years ago

http://masonry.desandro.com http://packery.metafizzy.co

Masonry has an advantage for dynamically resizing designs (@cornae correct me) and is MIT licensed. Both are very similar, so there is hope that we can mainly exchange the underlying js lib and keep most of the existing pat-packery code, calling it pat-masonry - and including it into patterns core.

cornae commented 9 years ago

Op 26 nov. 2014, om 13:01 heeft Alexander Pilz notifications@github.com het volgende geschreven:

http://masonry.desandro.com http://masonry.desandro.com/ http://packery.metafizzy.co http://packery.metafizzy.co/ Masonry has an advantage for dynamically resizing designs (@cornae https://github.com/cornae correct me)

That's based on hope, since our version of Packery is untameable in this respect. and is MIT licensed. Both are very similar, so there is hope that we can mainly exchange the underlying js lib and keep most of the existing pat-packery code, calling it pat-masonry - and including it into patterns core.

The second point is at least as important to us. The more vanilla Patterns we use, the simpler our process. — Reply to this email directly or view it on GitHub https://github.com/Patternslib/Patterns/issues/384.

jcbrand commented 9 years ago

I've created the pat-masonry pattern: https://github.com/Patternslib/pat-masonry

You can see a demo of it in action by cloning it:

git clone https://github.com/Patternslib/pat-masonry.git

and then running:

make designerhappy

The demo will then be available on http://localhost:4001

Please note, the pat-packery pattern renamed some of the packery configuration options. For example, packery accepts transition-duration and pat-packery renamed it to transition-speed.

I don't know why this was done, but transition-speed is in any case the wrong name.

For pat-masonry, I've kept the config parameters exactly the same as what masonry accepts. This way, the masonry docs apply also to the pattern and you don't have to remember 2 different sets of config parameters (i.e. one for masonry and one for pat-masonry).

This means however that if we are doing to replace pat-packery with pat-masonry in sites where it's being used, some of the config settings need to be renamed as well.

cornae commented 9 years ago

@pilz, Lets roll this out in White Side on monday.

jcbrand commented 9 years ago

Hi @cornae I've now moved pat-masonry to Patterns core. I think you'll want to fix the CSS and markup of the pattern's documentation.

https://github.com/Patternslib/Patterns/tree/master/demo/masonry