Hide Upload button - Githubissues

fulv commented 9 years ago

Currently the Upload button appears all the time, which is not right.

fulv commented 9 years ago

@cornae, could you please try the demo and let me know if it does what you need? go to pat-upload repository git pull make designerhappy Go to http://localhost:4001/demo/ to see the demo

cornae commented 9 years ago

The demo runs with the make file. This is already good news. Also good news is that one of the 3 things I needed works also: The upload button only appears after dragging something on the component. Dit you already fix that or is there a version issue with the one in PI?

The 2 remaining things:

A property label:. With which I may influence the text that currently reads 'Drop files here...', defaulting to 'Drop files here…' (But then with a real ellipsis instead of three dots)
A property trigger:. With which I may influence what triggers the upload. Defaulting to value button which leaves the current behaviour unchanged. A value auto would always hide the upload button and start uploading automatically after the user drags something on.

Op 17 dec. 2014, om 15:37 heeft Fulvio Casali notifications@github.com het volgende geschreven:

@cornae https://github.com/cornae, could you please try the demo and let me know if it does what you need? go to pat-upload repository git pull make designerhappy Go to http://localhost:4001/demo/ to see the demo

— Reply to this email directly or view it on GitHub https://github.com/Patternslib/pat-upload/issues/2#issuecomment-67330466.

fulv commented 9 years ago

Yes, @cornae, it was my fix that makes the upload button only appear after dragging something on the component.

fulv commented 9 years ago

I have added a label property.

cornae commented 9 years ago

Fab.

Op 23 dec. 2014, om 12:52 heeft Fulvio Casali notifications@github.com het volgende geschreven:

Yes, @cornae, it was my fix that makes the upload button only appear after dragging something on the component.

— Reply to this email directly or view it on GitHub.

cornae commented 9 years ago

Label property works great. I've tweaked only a few triple dots to ellipses and the content of the default line.

What about the trigger property?

fulv commented 9 years ago

I added the trigger property. Merry Christmas!

cornae commented 9 years ago

Great! Is this all available also in the PI proto already? Buon Natale anche a te! :)

Op 25 dec. 2014 om 09:20 heeft Fulvio Casali notifications@github.com het volgende geschreven:

I added the trigger property. Merry Christmas!

— Reply to this email directly or view it on GitHub.

fulv commented 9 years ago

I still don't know exactly how the updating of patterns into PloneIntranet happens. I'll try later.

Patternslib / pat-upload

Hide Upload button #2