Re-add 'HTML_NAMESPACE' (used in tests)

Pauan / rust-dominator

Zero-cost ultra-high-performance declarative DOM library using FRP signals for Rust!

MIT License

967 stars 62 forks source link

Re-add 'HTML_NAMESPACE' (used in tests) #28

Open njam opened 4 years ago

njam commented 4 years ago

Just making the code compile

cargo check --all-targets

The const HTML_NAMESPACE is used in the same file, in the tests module. Not sure if you prefer defining the constant in the tests module, to avoid it being "dead code"?

njam commented 4 years ago

Hm, the tests are using DomBuilder, but html! is creating Dom. I've now replaced DomBuilder::new(create_element_ns(...)) with DomBuilder::new_html(...), does that make sense?

njam commented 4 years ago

btw, how are you running the tests? :D

I tried running tests with "wasm-bindgen-test" in Chrome, and got 3/6 failing tests.

Pauan commented 2 years ago

Oh, I'm sorry, I somehow missed this issue. I don't actually run any of the tests, I just use them for compile-time type checking.