Add docs to lib.rs + macros.rs. Simplify clone!

Pauan / rust-dominator

Zero-cost ultra-high-performance declarative DOM library using FRP signals for Rust!

MIT License

960 stars 62 forks source link

Add docs to lib.rs + macros.rs. Simplify clone! #49

Open pauldorehill opened 2 years ago

pauldorehill commented 2 years ago

Hi @Pauan,

I've started adding some docs based on my experience of using dominator and also all the gold in the Discord that we get from asking you questions 😄 . I also updated the clone macro which may constitute a breaking change...

iMplode-nZ commented 2 years ago

@Pauan these docs are very nice, could you mind merging it?

evelant commented 2 years ago

These docs are very helpful! They would have helped me understand dominator a lot more easily and quickly. @Pauan anything blocking merging these?

Pauan commented 2 years ago

@AndrewMorsillo It's just a very large change, so I haven't been able to find the time to review it.

derekdreery commented 2 years ago

@Pauan would it be OK if someone other than you reviewed it?

pauldorehill commented 9 months ago

It was a long time since I submitted this, however I'm still using Dominator regularly. I could easily change it to one macro at a time etc.

Pauan commented 9 months ago

@TristanCacqueray Yes, small bite-sized pull requests are much much much much easier to review, since I don't need to devote a large chunk of time to reviewing it. Ideally a pull request per method / macro.