search

Pauan / rust-signals

Zero-cost functional reactive Signals for Rust
MIT License
677 stars 37 forks source link

Clone impl for Broadcaster #48

Closed simon-bourne closed 2 years ago

simon-bourne commented 2 years ago

Is there any reason why Clone isn't implemented for Broadcaster?

Pauan commented 2 years ago

I don't think there's any particular reason, it just hasn't been done yet.

simon-bourne commented 2 years ago

Great, it looked like it'd be easy to add as it's just an Arc inside, and the implementations of Broadcaster::signal* looked like they'd work on a clone of the Arc, but wanted to check. Would you take a pull request?

Pauan commented 2 years ago

Thanks for the offer, but I already implemented it, it'll be in the next release.

simon-bourne commented 2 years ago

Even better, thanks!

Pauan commented 2 years ago

This was released in version 0.3.25