search

Pauan / rust-signals

Zero-cost functional reactive Signals for Rust
MIT License
675 stars 37 forks source link

Fix of out of bound remove index in flatten #80

Closed martin-kolarik closed 7 months ago

martin-kolarik commented 10 months ago

Solves #79.

martin-kolarik commented 10 months ago

Solves #81.

Pauan commented 10 months ago

Nice catch, though I think a better solution is to just reverse the RemoveAt, since that's more efficient.

martin-kolarik commented 10 months ago

Exactly, I was considering it, but then I chose "less changes".

Pauan commented 7 months ago

Sorry for the delay, I decided to go with the rev() implementation instead. Thanks for the report!