search

Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
63 stars 8 forks source link

Certain URLs can break Tab Organizer #125

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 126

What steps will reproduce the problem?
1. Open an URL like http://www.google.com/% 
2. Try to open Tab Organizer
3.

What is the expected output? What do you see instead?
Tab Organizer shows the open tabs/windows. Instead, it acts as if no windows are open.
Console shows that the decodeURI call is throwing an URI malformed error.

What version of the product are you using? On what operating system?
Tab Organizer 3.5 on Chromium 10.0.635.0 (70951) / Windows.

Please provide any additional information below.

Reported by temp01irc on 2011-01-12 13:35:30

Pauan commented 9 years ago 
Oh boy, this could be tricky... I don't like the idea of writing my own URI decoder.
In any case, thanks for finding this, I'll see if there's an easy fix. At the very
least, I could wrap it in a try catch block, so one bad URL doesn't break the whole
thing.

Reported by pcxunlimited on 2011-01-13 03:52:27

Pauan commented 9 years ago 
This issue was updated by revision e8a3d3fe62.

Reported by pcxunlimited on 2011-01-13 04:03:50

Pauan commented 9 years ago 
I just threw a try catch block in there, which seems to do the trick.

Reported by pcxunlimited on 2011-01-13 04:04:20

Pauan commented 9 years ago

Reported by pcxunlimited on 2011-01-28 07:54:30

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:48