search

Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
67 stars 8 forks source link

Tab Organizer stopped working in recent chromium builds #129

Open Pauan opened 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 130

What steps will reproduce the problem?
1. Download a build from http://build.chromium.org/f/chromium/continuous/LATEST/
2. Install Tab Organizer
3. Click the action button

What is the expected output? What do you see instead?
It opens and shows all open tabs. It's empty.

What version of the product are you using? On what operating system?
Chromium 10.0.652.0. Tab Organizer - Version: 3.6. Windows 7.

Please provide any additional information below.
This is the error in console:
UI%20Helper.js:51    Uncaught SyntaxError: Octal literals are not allowed in strict
mode.

There were changes to v8 related to strict mode and now Chrome correctly doesn't allow
octal escape sequences like "\0". Changing it to "\x00" should fix it.

Reported by temp01irc on 2011-01-28 10:05:49

Pauan commented 9 years ago 
Isn't \0 supposed to be null? I'm using that as a trick to make the tooltip popup NOT
appear. Setting title to "" doesn't work. Using spaces doesn't work. But using \0 does.
I'll try \x00 and see if that still has the desired effect.

Reported by pcxunlimited on 2011-01-28 19:56:50

Pauan commented 9 years ago 
Alright, I changed \0 to \x00.

("\0" === "\x00") is true, so I don't think it'll cause any problems.

This is important enough to make another release. Thanks for the good report.

Reported by pcxunlimited on 2011-01-28 20:01:40

Pauan commented 9 years ago 
I just pushed out version 3.6.5. Please tell me if this bug is still occurring with
that version or not.

Reported by pcxunlimited on 2011-01-28 20:08:02

Pauan commented 9 years ago 
Works fine now (after updating to v3.6.5). Thanks for the quick update.

Reported by temp01irc on 2011-01-29 00:58:47

Pauan commented 9 years ago 
Good, good. Seems a little weird that null would be counted as an octal escape. Either
way, I'm glad that the fix was easy.

Reported by pcxunlimited on 2011-01-29 09:18:10

Pauan commented 9 years ago 
After your comment, I checked FF4 and noticed that it allows \0 in strict mode. So I
filed an issue for v8 (issue v8:1084) after confirming in #v8 channel.

Reported by temp01irc on 2011-01-29 11:49:06

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:48