search

Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
67 stars 8 forks source link

Tab Organizer broken in recent Chromium build (strict mode error) #140

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 141

What steps will reproduce the problem?
1. Open Tab Organizer or try to open the Options page
2.
3.

What is the expected output? What do you see instead?
It should work and show the open tabs. But instead, both pages are blank.

What version of the product are you using? On what operating system?
Tab Organizer 3.8. Chromium 11.0.698.0 (77555). Windows 7.

Please provide any additional information below.

The function definition inside the if(){} block in "UI Helper.js" on line 157 is invalid
in strict mode. Chrome throws an "Uncaught SyntaxError: In strict mode code, functions
can only be declared at top level or immediately within another function. - UI%20Helper.js:157"
error. See the screenshot.

Reported by temp01irc on 2011-03-10 19:47:14

Pauan commented 9 years ago 
Uh, my bad. The broken extension was actually a locally loaded Tab organizer from some
time ago (v 3.3) which somehow got enabled. So I had two versions of Tab Organizer
running side by side and didn't notice. v3.8 is working just fine - this issue can
be closed.

Reported by temp01irc on 2011-03-11 06:05:16

Pauan commented 9 years ago 
Oooh, right, I had one of those errors, but in a different area. Interesting that strict
mode disables that. I think it's a good thing overall, though. I mostly try not to
write function blocks within if statements, but occasionally it happens.

Reported by pcxunlimited on 2011-03-18 12:43:05

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:48