search

Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
67 stars 8 forks source link

When a window's focus changes, sometimes it doesn't update. #16

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 16

What steps will reproduce the problem?
1. Open the Tab Organizer popup.
2. Use it for a while, selecting different windows within Chrome.

What is the expected output? What do you see instead?
It should correctly show which window is selected, within Tab Organizer.

However, sometimes it stops updating, and the only way to fix it is to refresh the
popup.

Please provide any additional information below.
It appears to be a sync issue with Options.addEventListener and Options.triggerEvent...

Reported by pcxunlimited on 2010-09-03 18:42:14

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-05 00:11:10

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-05 21:51:04

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-06 01:14:10

Pauan commented 9 years ago 
I also need Options unit tests for this scenario.

Reported by pcxunlimited on 2010-09-06 01:14:43

Pauan commented 9 years ago 
Well, I've been using Tab Organizer for a while now, and haven't noticed this behavior.
I'm going to assume this is fixed. If it comes up again, I can reopen this issue.

Reported by pcxunlimited on 2010-09-12 04:36:56

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-12 05:17:54

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-12 08:11:54

Pauan commented 9 years ago 
I managed to trigger this again. I can't tell what the reproduction steps are, though.

I do know this much: it appears to be a problem where Options events become duplicated
without being properly removed.

Reported by pcxunlimited on 2010-09-12 09:11:51

Pauan commented 9 years ago 
This issue was updated by revision 557dc15283.

Update issue 34
Status: Pending

Reported by pcxunlimited on 2010-09-12 16:02:56

Pauan commented 9 years ago 
Okay, hopefully this is fixed for real this time. I added in a "try...catch" block that
should prevent this from happening again. I still need to fix the root cause, though,
which is events not being cleaned up correctly.

Reported by pcxunlimited on 2010-09-12 16:04:30

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-16 21:15:16

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 21:56:56

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:47