search

Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
66 stars 8 forks source link

Popup does not immediately sync with the options page. #43

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 43

What steps will reproduce the problem?
1. Open the popup.
2. Change some options.
3. Look at the popup.

What is the expected output? What do you see instead?
The options should be changed immediately. Instead, I need to refresh the popup before
the changes take place.

Please provide any additional information below.
Some options we can't really change while the popup is loaded. However here is the
list of things we can change, but don't:

* popup.type
* tabs.close.display
* usage-tracking

The problem with changing "popup.type" is that a user may not like having Tab Organizer
automatically close and then reopen itself when they merely wanted to change the option.

The problem with "tabs.close.display" is that it would probably require adding a "change"
event to every tab. This is really bad because that would mean that every time any
option changes, it needs to trigger once for each tab!

One hack we could try is to add a single "change" event, that grabs all the close buttons
and then changes them. That would avoid a lot of the performance costs, but could be
a tad tricky to implement.

The problem with "usage-tracking" is that I'm not sure if it's even possible to stop
Google Analytics without a page refresh.

Reported by pcxunlimited on 2010-09-15 14:41:07

Pauan commented 9 years ago 
For the same reasons as "tabs.close.display", we also don't immediately change "tabs.close.location"
either.

Reported by pcxunlimited on 2010-09-15 14:42:14

Pauan commented 9 years ago 
I'm leaning toward marking this as WontFix:

* I don't want to change the behavior of popup.type, as that could be confusing to
users.

* Changing tabs.close.display and tabs.close.location would add a lot of extra complexity
and a small performance hit, for very little gain.

* Not sure if changing usage-tracking immediately is even possible, and the benefits
would be almost nonexistent. Any further visits to window.html or options.html are
not recorded after making the change, so this only affects pages that are open while
changing the setting.

Reported by pcxunlimited on 2010-09-16 21:31:38

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-18 17:11:05

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-10-02 20:49:30

Pauan commented 9 years ago 
This issue was updated by revision 3471fadc48.

Reported by pcxunlimited on 2010-10-02 21:32:41

Pauan commented 9 years ago 
It was pretty easy to make tabs.close.display and tabs.close.location work.

I decided to not immediately change popup.type, due to the possible user confusion.

After doing a tiny bit of research, I'm still not sure whether changing usage-tracking
immediately would be feasible or not. Either way, it isn't a big deal, since stats
won't be recorded for any further visits.

This is about as good as it gets, for now.

Reported by pcxunlimited on 2010-10-02 21:35:42

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-10-17 17:04:03

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-11-21 18:49:48

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:47