Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
66 stars 8 forks source link

Changes are not saved while using bubble mode. #47

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 47

What steps will reproduce the problem?
1. Switch to bubble mode in the options page.
2. Open the bubble.
3. Change the titles, the search query, etc.
4. Close the bubble.
5. Reopen the bubble.

What is the expected output? What do you see instead?
The titles and last-used search query should still be there. Instead, they're gone!

What version of the product are you using? On what operating system?
Version 2.8 on Debian GNU/Linux Lenny 5.0.6

Please provide any additional information below.
This used to work. I think I know why this is broken, so it should be an easy fix.
Luckily, it only breaks in bubble mode!

It appears that the "beforunload" event is not fired for bubble mode. So I just need
to change it to use "unload" instead.

Reported by pcxunlimited on 2010-09-16 21:08:14

Pauan commented 9 years ago
This issue was updated by revision 1b33a447de.

Reported by pcxunlimited on 2010-09-17 13:52:07

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-18 15:04:18

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-09-19 18:02:54

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:47