Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
63 stars 8 forks source link

Add a close/save button to the options page. #97

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 95

Ok, so this has happened multiple times now. I'm just so used to clicking the OK/Cancel
button that I always click the Cancel button after changing options. I recognize the
Reset to Default button (it's wide) but always think of the Cancel button as Close
(I just click it without it looking). Since changing Tab Organizer's options is something
I rarely do, I'm not used to it and probably will never be. Not to mention it's harder
to move mouse up to the tab area and then click that small X (vs. a button) or press
the keyboard shortcut.

IMO, Reset to defaults should be on bottom-left corner and there should be a Close
button in place of the Reset button.

Feel free to close this if you're not going to change it.

Reported by temp01irc on 2010-11-08 18:30:05


Pauan commented 9 years ago
I did worry about this when designing the options page. I don't like the placement,
though. On GNU/Linux, it's "Apply", then "Cancel", then "OK"; with "OK" being the right-most.

If Windows does something different, then it will be difficult to make it consistent
across OS's. Rather than try to copy existing OS's (due to their inconsistencies),
I instead strove to make Tab Organizer consistent within itself.

In any case, I agree this is a problem, but I'm not entirely sure what the best way
to solve it is. I could present a confirm dialog box, "Are you sure you want to cancel?"
but that would probably be rather annoying.

Reported by pcxunlimited on 2010-11-09 05:47:57

Pauan commented 9 years ago
P.S. The new Settings page within Chrome itself, has neither a "Cancel" nor a "Close"
button, and the "Reset to Defaults" is tucked away in the advanced section.

One idea is to get rid of the "Cancel" button completely, replacing it with "Close".
Neither gedit nor pidgin has a "Cancel" button on my machine. In which case, there's
the obvious question: does anybody want or need a "Cancel" button?

Reported by pcxunlimited on 2010-11-09 05:52:11

Pauan commented 9 years ago
Also, as a side note, here's the part of the GNOME HIG that deals with options pages:

http://library.gnome.org/devel/hig-book/stable/windows-utility.html.en

Reported by pcxunlimited on 2010-11-09 05:57:08

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-11-16 09:00:11

Pauan commented 9 years ago
This issue was updated by revision ebde33535d.

Reported by pcxunlimited on 2010-11-17 01:25:30

Pauan commented 9 years ago
I decided to just change "cancel" to "close". This should be in version 3.4 (not released
yet).

Reported by pcxunlimited on 2010-11-17 01:30:40

Pauan commented 9 years ago

Reported by pcxunlimited on 2010-12-13 01:00:59

Pauan commented 9 years ago
Version 3.4 is out now, so hopefully this won't be a problem anymore.

Reported by pcxunlimited on 2010-12-13 01:01:54

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:48