Paul-Austin-Oswego-CSC480-HCI521 / OZ-CSC-480-HCI-521-Fall-2024

Repo for CSC 480 HCI 521 class of fall 2024
5 stars 16 forks source link

Task name doesn't sort correctly on any projects page #113

Closed jbaile20 closed 13 hours ago

jbaile20 commented 2 weeks ago

Problem

When sorting on any project page, the task description doesn't sort alphabetically

Incidence

Steps to reproduce

Environment

OS: Windows Browser: Chrome Branch: Gui-init (d8aba03)

Subheadings below are optional; remove if not applicable.

Location

Behavior

Expected behavior

Correctly sorts alphabetically

Observed behavior

Doesn't sort alphabetically

Subheadings below are optional; remove if not applicable.

Console output/errors

Screenshot

image

Top-level headings below are optional; remove if not applicable.

Suggested fix

Other notes

Task Names DO correctly sort on the My Tasks page, just not on any projects page

Remember to assign the issue exactly one severity label.

SmartGarlic commented 1 week ago

On further examination of this it appears to be case sensitive. When a task is labeled "Bananas" vs "bananas", the lower case version will not sort correctly but the upper case will. Additionally this does not function on the My Tasks or Project pages.

MSCompSci commented 1 day ago

It turns out that this kind of sorting was due to the built-in sorting function used by the tanstack table library. The alphanumeric function was being used instead of the alphanumericCaseSensitive function that actually takes the case into account when sorting. I opened a PR that should fix this #127

MSCompSci commented 13 hours ago

There were still issues with sorting even after changing to alphanumericCaseSensitive, but hopefully this PR should work #134

jbaile20 commented 13 hours ago

Yep, #134 seems to fix it. Thank you!