search

Paul-DS / bootstrap-year-calendar

[DEPRECATED] A fully customizable year calendar widget, for boostrap !
Apache License 2.0
294 stars 243 forks source link

Bootstrap 4 integration #170

Open maximedotair opened 6 years ago

maximedotair commented 6 years ago

Hello, Any fork for bootstrap 4 integration ? Best Regards

fergalddaly commented 6 years ago

I'm also interested in using this but with Bootstrap 4. Any idea when that is sorted ? Are there are suggested alternatives in the event of a no response ?

neivars commented 6 years ago

Check out my fork for a Bootstrap 4 integration. Migrated the classes that relied on deprecated BS3 classes and it should work. BS4 no longer uses glyphicons, so I used open-iconic as a dependency, as it was one of their recommended sources for icons (https://getbootstrap.com/docs/4.0/extend/icons/)

Paul-DS commented 5 years ago

The library does not depend so much on bootstrap. I was thinking to maybe migrate the project to get rid of bootstrap.

In this case, the library would become a "jquery-year-calendar", or even "js-year-calendar" if we remove the dependency to jquery. Then we could think of adding some themes (bootstrap, material, etc...), so the current users could keep a "bootstrap" version of the calendar.

I suppose that people here might not see clearly the interest of going in this direction, but it could be good to open this library to other developers who don't use bootstrap (I can't find any library that does the same kind of calendar in pure js or for other frontend frameworks).

What do you think ?

mennolodder commented 5 years ago

For my project (Angular, material design) we searched for a year calender, and this definitely is the only one we've found for javascript or angular.

We only use jquery and bootstrap for this part of the application. So we would welcome fewer dependencies. For branding it might also 'scare' fewer people off, if the name does not contain either technology. When replacing bootstrap I expect (without checking) that you might need to do something else to keep the kalendar responsive to different widths.

anlambert commented 5 years ago

Hi,

First sorry for having created #225, I did not spot this issue.

I think the idea of decoupling the calendar logic and the css themes is great. For instance, the DataTables library is proceeding that way (see https://github.com/DataTables/DataTables/tree/master/media/css or https://www.npmjs.com/~datatables).

trussss commented 5 years ago

Hi, Any news about that? Will you do that? or it is in progress?

anlambert commented 5 years ago

For those interested, I have published a Bootstrap 4 compatible version of the library under the name bootstrap-year-calendar-bs4.

I simply used PR #178 from @neivars and fixed the package.json file for that release. The associated repository can be found here: https://github.com/anlambert/bootstrap-year-calendar-bs4.

fergalddaly commented 5 years ago

While this is an excellent calendar, I'm working with Angular now and I am a bit reluctant to introduce this into the project. It would be excellent if a Angular wrapper was created for this (or even better if it was rewritten properly). I expect that it would be very popular as I can't see any alternatives that are quite as good as this.

anlambert commented 5 years ago

I agree with you @fergalddaly , the library is great and useful.

As commented above (https://github.com/Paul-DS/bootstrap-year-calendar/issues/170#issuecomment-427119850), decoupling the calendar logic from the graphical themes would be the right way to go here but I honestly do not have time to work on a PR for this.

Meanwhile, as bootstrap 4.x has been released a year ago and become widely used, I thought it was a pity not to offer a compatible version of the library, considering the port was successfully done in #178 .

If there is some move in this repo, implementing the solution proposed in https://github.com/Paul-DS/bootstrap-year-calendar/issues/170#issuecomment-427119850, I will of course deprecate the bootstrap-year-calendar-bs4 package.

Paul-DS commented 5 years ago

I created a new organization to manage the future versions of the project: https://github.com/year-calendar/

The library has been decoupled from bootstrap and jquery: https://github.com/year-calendar/js-year-calendar I also created a React wrapper: https://github.com/year-calendar/rc-year-calendar

If anyone is interested to participate to this new project, please reply here: https://github.com/year-calendar/js-year-calendar/issues/1