search

Paul-DS / bootstrap-year-calendar

[DEPRECATED] A fully customizable year calendar widget, for boostrap !
Apache License 2.0
293 stars 243 forks source link

dataSource border rendering issue #34

Open Wooya opened 8 years ago

Wooya commented 8 years ago

Hi! I've noticed an issue with border rendering in _renderDataSourceDayfunction. There's a line 373:

for (var i in events)

it causes strange behavior in Chrome 51.0.2704.103 m - borders aren't rendered: image and boxShadowresult looks like below:

inset 0 -4px 0 0 #45A597,inset 0 -NaNpx 0 0 undefined,inset 0 -NaNpx 0 0 undefined,inset 0 -NaNpx 0 0 undefined

When I've changed line 373 to:

for (var i = 0; i < events.length; i++)

then calendar's borders are rendered correctly: image

przywartya commented 8 years ago

Same problem here. Good job @Wooya

Paul-DS commented 7 years ago

Fixed ! Thank you for your contribution.

przywartya commented 7 years ago

And there is this bug I cannot really show one day daterange on the calendar. It just does not show it I can' figure out why. I set up start and end date as the same one and it doesn't work :/ Also, can you update your package on npm? :)

2016-09-18 12:27 GMT+02:00 Paul-DS notifications@github.com:

Fixed ! Thank you for your contribution.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Paul-DS/bootstrap-year-calendar/issues/34#issuecomment-247839764, or mute the thread https://github.com/notifications/unsubscribe-auth/ARIg4nJ9x-pbk4gVqZ6fsGKnsxlq9xGjks5qrRH2gaJpZM4JOf3D .