Responsive support makes switching years (rendering) very jerky

[mgamulin]

Problem is with how responsive support is implemented, month container initially has no col-xx-yy classes thus has full width and all months are rendered beneath each other.

Responsive column class is calculated with

        /* Responsive management */

        setInterval(function() {
            var calendarSize = $(_this.element).width();
            var monthSize = $(_this.element).find('.month').first().width() + 10;
            var monthContainerClass = 'month-container';

            if(monthSize * 6 < calendarSize) {
                monthContainerClass += ' col-xs-2';
            }
            else if(monthSize * 4 < calendarSize) {
                monthContainerClass += ' col-xs-3';
            }
            else if(monthSize * 3 < calendarSize) {
                monthContainerClass += ' col-xs-4';
            }
            else if(monthSize * 2 < calendarSize) {
                monthContainerClass += ' col-xs-6';
            }
            else {
                monthContainerClass += ' col-xs-12';
            }

            $(_this.element).find('.month-container').attr('class', monthContainerClass);
        }, 300);

This can be removed altogether if creation of "month-container" inside _renderBody is changed from

...
/* Container */
var monthDiv = $(document.createElement('div'));
.addClass('month-container');
...

to something like

...
/* Container */
var monthDiv = $(document.createElement('div'));
monthDiv.addClass('month-container col-xs-12 col-sm-4 col-md-3 col-lg-2');
...

It would be even better if new option for responsive column classes is introduced.

[mmuman]

Besides, the setInterval calls are not paired with clearInterval, so each time it adds a new timer instead of replacing it...

[mmuman]

I tried using those classes but in practice the months overlap quite a lot in most cases. 😕

[mmuman]

Oh, and it's always setting the class, instead of only setting it when it does actually change, forcing the browser to relayout everything without any valid reason every time... It's visible in the inspector, the class strings stay highlighted... Using this makes it much less CPU intensive:

                $(_this.element).find('.month-container').each(function() {
                    if ($(this).attr('class') != monthContainerClass)
                        $(this).attr('class', monthContainerClass);
                });

[mmuman]

I've made yet another optimization, by using a separate method that's also called at the end of render, so the 1 month/column isn't shown anymore. I'll make a PR later on.

[mmuman]

... and the months-container lacks the "row" class, it gets overlapped by other columns when in another grid layout...

[roooodcastro]

I also suggest changing this to the suggested way. There's no point using Bootstrap's responsive grid classes this way, it just hinders performance and make it difficult for others to customize things.

Also, it would be awesome if these classes (col-xs-12, col-md-4, etc) were mapped in the options object, so anyone could change them (would instantly make compatibility with Bootstrap 4 feasible)

[mmuman]

Oh dear, 6 months have passed. I'll try to clean this up for merge.

[IvanBica]

any solution for this ?

[mmuman]

Didn't have much time this year… I'll try to dig the patches and open a PR, but I won't have time to write a test case.

[IvanBica]

Fix it, you have to replace it

$(_this.element).find('.month-container').attr('class', monthContainerClass);

for

$(_this.element).find('.month-container').addClass(monthContainerClass);

[mmuman]

Right, addClass is cleaner.

[mmuman]

Hmm, looking at the code again, I don't think we want to addClass, we really want to replace the previous bootstrap class. Note monthContainerClass always contains "month-container" and is appended with the correct bootstrap layout class.

[mmuman]

Ok, here's my fix for it, please test. I have some more little patches (to disable the fadein, and to force the column count for things like wkhtmltopdf) but that can wait.