search

Paul-Ladyman / dnd-battle-tracker

D&D Battle Tracker is a combat management tool for Dungeons & Dragons 5th Edition.
https://dndbattletracker.com/
MIT License
21 stars 8 forks source link

Consolidate shared battle loading states #641

Open Paul-Ladyman opened 3 months ago

Paul-Ladyman commented 3 months ago

Currently a loading spinner is displayed when waiting for a battle to be shared. There is then a second loading state which displays "..." in the sub title whilst waiting for the player session link to be copied. This state should be removed and the loading spinner displayed until everything is ready or until an error occurs when a suitable error message should be displayed. This will probably require moving the copying of the link up from the sub title component to a higher level where it makes sense to activate the loading screen.

Paul-Ladyman commented 3 months ago

This will also resolve https://github.com/Paul-Ladyman/dnd-battle-tracker/issues/450