search

Paul-js-hub / gym-instructor-backend

A back end API that has gym services
3 stars 0 forks source link

ROR Capstone Project #19

Open Paul-js-hub opened 1 year ago

Paul-js-hub commented 1 year ago

This is the link to our GitHub project. We are a team of 5 members:

Kanban Board Screenshot capstone

Meltrust commented 1 year ago

Hi @Paul-js-hub,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

You can do it

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Meltrust commented 1 year ago

Hi, @Paul-js-hub,

Wow, you did it πŸŽ‰

Brilliant

Thank you for implementing the changes requested by the previous reviewer πŸ’ͺ πŸ₯‡ γŠ—οΈ

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! πŸŽ‰

To highlight

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.