search

PaulBGD / react-native-image-slider

A quick and easy image slider for react native. Maintainer wanted!
MIT License
237 stars 103 forks source link

Warning: componentWillMount is deprecated #82

Open puremana opened 5 years ago

puremana commented 5 years ago

Thank you guys for your work and continued supported of this wonderful package.

Just thought I would give you a heads up that I am getting warning errors regarding componentWillMount being deprecated in the next major version.

9b01b6528d14853b00689d8cc2889c10

ArtiomShapovalov commented 5 years ago

I will look into it sometime

Maskedman99 commented 5 years ago

It was announced that the React lifecycle methods componentWillReceiveProps, ComponentWillMount, and componentWillUpdate will be deprecated in a future version of React. This is because of the eventual migration of React to async rendering; these lifecycle methods will become unreliable when async rendering is made default. In place of these methods, the new static method getDerivedStateFromProps was introduced. https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

Boubaker93 commented 4 years ago

this pull request https://github.com/PaulBGD/react-native-image-slider/pull/90 fixes the problem.

idanlevi1 commented 4 years ago

I will look into it sometime

can you merge the PR? #90

francistec commented 1 year ago

Still having the same error